fix(tests): fixed test_push.py::test_stack_overflow
test by reducing contract size to below allowed max
#2002
+20
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Issue is described in #1699, ty for reporting!
How to run
First run reth via:
reth node --dev --chain dev --http --authrpc.addr 127.0.0.1 --http.port 8545
then run:
uv run execute remote -m state_test --fork=Shanghai --rpc-endpoint=http://127.0.0.1:8545 --rpc-seed-key=2a871d0798f97d79848a013d4936a73bf4cc922c825d33c1cf7073dff6d409c6 --rpc-chain-id=1337 --tx-wait-timeout 60 -vv -s tests/frontier/opcodes/test_push.py::test_stack_overflow
Before this PR it failed from PUSH23 onwards due to max contract size (24576) exceeded. After this PR everything passes. I also tried filling and consume direct with geth's evm and it all passes. Ty for the push0 idea @marioevz !
🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.